Pin E2E_TRACE_IDS_PATH in testnet run-local.sh#106
Merged
Conversation
run-all.sh exports E2E_TRACE_IDS_PATH so suite 3 writes the trace IDs
to <repo>/e2e/e2e-trace-ids.json and suite 4's verifier finds them at
the same path. run-local.sh was missing the same export, so suite 4
always failed with NotFound on local stack runs:
NotFound: No such file or directory (os error 2):
readfile '<repo>/e2e/e2e-trace-ids.json'
Pin the path the same way run-all.sh does. Suites 3 and 4 of
`./testnet/run-local.sh all` now both pass against local Jaeger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testnet/run-all.shexportsE2E_TRACE_IDS_PATH=\$REPO_ROOT/e2e/e2e-trace-ids.jsonso suite 3 (lifecycle flow) writes the trace IDs to the same path suite 4's verifier reads from.run-local.shwas missing the equivalent export — suite 3 fell back to the CWD default (<repo>/e2e-trace-ids.json), suite 4 still looked ine2e/, and the local Jaeger verifier failed with:```
NotFound: No such file or directory (os error 2):
readfile '/e2e/e2e-trace-ids.json'
```
Pre-existing — independent of the dashboard-rework work that landed in #104. Surfaces only when running suite 4 via
./testnet/run-local.sh.Test plan